Open
Conversation
added 2 commits
August 29, 2020 16:59
yurii-litvinov
suggested changes
Aug 29, 2020
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
В целом всё так, но надо больше тестов
| let holder = LazyFactory<obj>.LockMultiThreadLazy(fun () -> obj()) | ||
| let toCompare = holder.Get() | ||
| for i in 1..100500 do | ||
| holder.Get() |> should equal toCompare |
There was a problem hiding this comment.
Так это ж не многопоточно. Тесты пока нигде не проверяют, что если из нескольких потоков подёргать Lazy, всё хорошо будет. Тем более что самое интересное в многопоточном случае --- это гонки при первом Get, а тут он делается даже до цикла, так что если бы цикл был параллельным, это бы тоже было непоказательно
| open LockMultiThreadLazy | ||
| open LockFreeLazy | ||
|
|
||
| type LazyFactory<'a> = |
added 2 commits
September 11, 2020 22:32
yurii-litvinov
approved these changes
Sep 13, 2020
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Не проверяется, что в случае не-lock-free-многопоточного теста вызов supplier делается ровно один раз, но лучше, чем ничего, да. Зачтена.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.